From fa3ba150b17d0e013b080cc29c92bfb68bf6264c Mon Sep 17 00:00:00 2001 From: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com> Date: Thu, 10 Nov 2022 20:16:14 +0300 Subject: deleted reduntant length fields - improved struct append --- packets/messages/types/NetSetConVar.go | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) (limited to 'packets/messages/types/NetSetConVar.go') diff --git a/packets/messages/types/NetSetConVar.go b/packets/messages/types/NetSetConVar.go index b502953..eca05e0 100644 --- a/packets/messages/types/NetSetConVar.go +++ b/packets/messages/types/NetSetConVar.go @@ -3,7 +3,6 @@ package types import "github.com/pektezol/bitreader" type NetSetConVar struct { - Length uint8 ConVars []ConVar } @@ -13,16 +12,15 @@ type ConVar struct { } func ParseNetSetConVar(reader *bitreader.ReaderType) NetSetConVar { - var convars []ConVar - netsetconvar := NetSetConVar{ - Length: reader.TryReadInt8(), - } - for i := 0; i < int(netsetconvar.Length); i++ { - convars = append(convars, ConVar{ + length := reader.TryReadInt8() + convars := make([]ConVar, length) + for i := 0; i < int(length); i++ { + convars[i] = ConVar{ Name: reader.TryReadString(), Value: reader.TryReadString(), - }) + } + } + return NetSetConVar{ + ConVars: convars, } - netsetconvar.ConVars = convars - return netsetconvar } -- cgit v1.2.3