deleted reduntant length fields - improved struct append

1 files changed, 12 insertions, 12 deletions

diff --git a/packets/messages/types/SvcClassInfo.go b/packets/messages/types/SvcClassInfo.go
index 58e43b7..fb9dbd8 100644
--- a/packets/messages/types/SvcClassInfo.go
+++ b/packets/messages/types/SvcClassInfo.go
@@ -7,7 +7,6 @@ import (
 )
 
 type SvcClassInfo struct {
-        Length         uint16
         CreateOnClient bool
         ServerClasses  []ServerClass
 }
@@ -19,24 +18,25 @@ type ServerClass struct {
 }
 
 func ParseSvcClassInfo(reader *bitreader.ReaderType) SvcClassInfo {
+        length := reader.TryReadInt16()
+        createonclient := reader.TryReadBool()
         var serverclasses []ServerClass
-        svcclassinfo := SvcClassInfo{
-                Length:         reader.TryReadInt16(),
-                CreateOnClient: reader.TryReadBool(),
-        }
-        if svcclassinfo.CreateOnClient {
-                for i := 0; i < int(svcclassinfo.Length); i++ {
-                        id, err := reader.ReadBits(int(math.Log2(float64(svcclassinfo.Length))) + 1)
+        if createonclient {
+                serverclasses := make([]ServerClass, length)
+                for i := 0; i < int(length); i++ {
+                        id, err := reader.ReadBits(int(math.Log2(float64(length))) + 1)
                         if err != nil {
                                 panic(err)
                         }
-                        serverclasses = append(serverclasses, ServerClass{
+                        serverclasses[i] = ServerClass{
                                 ClassId:       int32(id),
                                 ClassName:     reader.TryReadString(),
                                 DataTableName: reader.TryReadString(),
-                        })
+                        }
                 }
         }
-        svcclassinfo.ServerClasses = serverclasses
-        return svcclassinfo
+        return SvcClassInfo{
+                CreateOnClient: createonclient,
+                ServerClasses:  serverclasses,
+        }
 }